Dataplex data asset #16106

okvidhi · 2026-01-09T06:34:23Z

This PR introduces support for the google_dataplex_data_asset resource in the google-beta provider.
This implementation allows for the declarative management of data assets within a Data Product, enabling publishers to curate and share cloud resources like BigQuery datasets.

Key features

Hierarchical Resource Linkage: Established the parent-child relationship where the Data Asset is managed under a specific Data Product .
LRO Polling: Integrated asynchronous polling to ensure Terraform accurately tracks background asset creation and updates.
Access Group Configuration: Support for mapping access groups to specific IAM roles on the underlying cloud resource

Note
Stacked PR: This PR is built on top of the changes in the dataplex-data-products branch and is dependent on those changes being merged first.

`google_dataplex_data_asset`

…odules into dataplex-data-products

github-actions · 2026-01-09T06:35:25Z

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@rileykarson, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

github-actions · 2026-01-13T09:46:56Z

@rileykarson This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

github-actions · 2026-01-15T09:46:21Z

@GoogleCloudPlatform/terraform-team @rileykarson This PR has been waiting for review for 1 week. Please take a look! Use the label disable-review-reminders to disable these notifications.

modular-magician · 2026-01-15T20:33:54Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 483 insertions(+))
google-beta provider: Diff ( 10 files changed, 2685 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 2 files changed, 429 insertions(+))

Multiple resources added

This PR adds multiple new resources: google_dataplex_data_asset, google_dataplex_data_product. This makes review significantly more difficult. Please split it into multiple PRs, one per resource.
An override-multiple-resources label can be added to allow merging.

modular-magician · 2026-01-15T20:52:03Z

Tests analytics

Total tests: 77
Passed tests: 73
Skipped tests: 0
Affected tests: 4

Click here to see the affected service packages

dataplex

Action taken

Found 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccDataplexDataAsset_dataplexDataAssetBasicExample

TestAccDataplexDataAsset_dataplexDataAssetFullExample

TestAccDataplexDataProduct_dataplexDataProductBasicExample

TestAccDataplexDataProduct_dataplexDataProductFullExample

Get to know how VCR tests work

modular-magician · 2026-01-15T20:53:28Z

🟢 Tests passed during RECORDING mode:
TestAccDataplexDataAsset_dataplexDataAssetBasicExample [Debug log]
TestAccDataplexDataAsset_dataplexDataAssetFullExample [Debug log]
TestAccDataplexDataProduct_dataplexDataProductBasicExample [Debug log]
TestAccDataplexDataProduct_dataplexDataProductFullExample [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

🟢 All tests passed!

View the build log or the debug log for each test

rileykarson · 2026-01-15T20:26:36Z

mmv1/templates/terraform/examples/dataplex_data_product_basic.tf.tmpl

+  data_product_id = "{{index $.Vars "data_product_id"}}"
+  display_name    = "terraform data product"
+
+  owner_emails = ["[email protected]"]


Suggested change

owner_emails = ["terraform-test@google.com"]

owner_emails = ["gterraformtestuser@gmail.com"]

rileykarson · 2026-01-15T20:26:52Z

mmv1/templates/terraform/examples/dataplex_data_product_full.tf.tmpl

+  # UTF-8 verification
+  description     = "Updated with emojis 🚀 and brackets {test}"
+
+  owner_emails = ["[email protected]"]


Suggested change

owner_emails = ["terraform-test@google.com"]

owner_emails = ["gterraformtestuser@gmail.com"]

rileykarson · 2026-01-15T21:25:33Z

mmv1/products/dataplex/DataProduct.yaml

+#     - '{{data_product_id}}'
+import_format:
+  - 'projects/{{project}}/locations/{{location}}/dataProducts/{{data_product_id}}'
+  - '{{data_product_id}}'


Suggested change

- '{{data_product_id}}'

location always needs to be provided, I think?

rileykarson · 2026-01-15T21:26:39Z

mmv1/products/dataplex/DataProduct.yaml

+    api_name: 'name'
+    custom_flatten: 'templates/terraform/custom_flatten/name_from_self_link.tmpl'


Suggested change

api_name: 'name'

custom_flatten: 'templates/terraform/custom_flatten/name_from_self_link.tmpl'

These can be removed due to url_param_only: true

rileykarson · 2026-01-15T21:31:14Z

mmv1/products/dataplex/DataAsset.yaml

+id_format: 'projects/{{project}}/locations/{{location}}/dataProducts/{{data_product_id}}/dataAssets/{{data_asset_id}}'
+import_format:
+  - 'projects/{{project}}/locations/{{location}}/dataProducts/{{data_product_id}}/dataAssets/{{data_asset_id}}'
+  - '{{data_product_id}}/{{data_asset_id}}'


Suggested change

- '{{data_product_id}}/{{data_asset_id}}'

Same reasons as below

rileykarson · 2026-01-15T21:31:27Z

mmv1/products/dataplex/DataAsset.yaml

+    api_name: 'name'
+    custom_flatten: 'templates/terraform/custom_flatten/name_from_self_link.tmpl'


Suggested change

api_name: 'name'

custom_flatten: 'templates/terraform/custom_flatten/name_from_self_link.tmpl'

Same reasons as below

mmv1/products/dataplex/DataAsset.yaml

rileykarson · 2026-01-15T21:33:10Z

mmv1/templates/terraform/examples/dataplex_data_asset_basic.tf.tmpl

+  data_asset_id   = "{{index $.Vars "data_asset_id"}}"
+  resource        = "//bigquery.googleapis.com/projects/${google_bigquery_dataset.example.project}/datasets/${google_bigquery_dataset.example.dataset_id}"
+
+  # NOTE: access_group_configs is omitted to bypass backend group validation 


Could you elaborate on why this is needed? Internally would be fine.

…ht to 2026, and clean formatting

…ht to 2026, and clean formatting lint fix

okvidhi added 6 commits December 29, 2025 16:14

Complete Data Product resource POC with IAM

a0c2faa

Merge branch 'main' of https://github.com/GoogleCloudPlatform/magic-m…

c49f46e

…odules into dataplex-data-products

feat(dataplex): Add DataProduct resource support

bd0f98f

feat(dataplex): Add DataProduct resource support fixed lint

2cc69a9

Merge branch 'dataplex-data-products' into dataplex-data-asset

4909b92

feat(dataplex): Add DataAsset resource support

4505e59

modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Jan 9, 2026

github-actions bot requested a review from rileykarson January 9, 2026 06:35

feat(dataplex): add DataAsset support and fix DataProduct state panics

8bc0393

modular-magician added service/dataplex and removed awaiting-approval Pull requests that need reviewer's approval to run presubmit tests labels Jan 15, 2026

rileykarson reviewed Jan 15, 2026

View reviewed changes

okvidhi added 6 commits January 16, 2026 11:27

address reviewer comments: fix name property conflict, update copyrig…

207605a

…ht to 2026, and clean formatting

address reviewer comments: fix name property conflict, update copyrig…

6c0233b

…ht to 2026, and clean formatting lint fix

test(dataplex): add handwritten update test

292fda5

test(dataplex): add handwritten update test

d2ae269

fix(dataplex): move test imports inside version guard to fix GA CI

29a6c60

Merge branch 'dataplex-data-products' into dataplex-data-asset

561aada

modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Jan 18, 2026

github-actions bot requested a review from rileykarson January 18, 2026 18:29

Merge branch 'main' into dataplex-data-asset

5a83782

	owner_emails = ["terraform-test@google.com"]
	owner_emails = ["gterraformtestuser@gmail.com"]

		api_name: 'name'
		custom_flatten: 'templates/terraform/custom_flatten/name_from_self_link.tmpl'

Dataplex data asset #16106

Are you sure you want to change the base?

Dataplex data asset #16106

Conversation

okvidhi commented Jan 9, 2026

Uh oh!

github-actions bot commented Jan 9, 2026

Uh oh!

github-actions bot commented Jan 13, 2026

Uh oh!

github-actions bot commented Jan 15, 2026

Uh oh!

modular-magician commented Jan 15, 2026

Diff report

Multiple resources added

Uh oh!

modular-magician commented Jan 15, 2026

Tests analytics

Action taken

Uh oh!

modular-magician commented Jan 15, 2026

Uh oh!

rileykarson Jan 15, 2026

Choose a reason for hiding this comment

Uh oh!

rileykarson Jan 15, 2026

Choose a reason for hiding this comment

Uh oh!

rileykarson Jan 15, 2026

Choose a reason for hiding this comment

Uh oh!

rileykarson Jan 15, 2026

Choose a reason for hiding this comment

Uh oh!

rileykarson Jan 15, 2026

Choose a reason for hiding this comment

Uh oh!

rileykarson Jan 15, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

rileykarson Jan 15, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants